diff options
| author | t0kubetsu <[email protected]> | 2026-10-20 11:00:49 +0200 |
|---|---|---|
| committer | Tomas Mraz <[email protected]> | 2026-10-23 14:49:38 +0200 |
| commit | 11d83607b8152c77e1175190e42034c5a6f6e77c (patch) | |
| tree | af37ba09e1d5b8ccbf44730d5e8daf37f6f5e639 | |
| parent | Document the OSSL_PARAM_merge() entry limit (diff) | |
| download | openssl-11d83607b8152c77e1175190e42034c5a6f6e77c.tar.gz openssl-11d83607b8152c77e1175190e42034c5a6f6e77c.zip | |
poly1305-armv9-sve2.pl: close STDOUT before exiting
The last line of the script was " STDOUT or die ...", without the
"close" keyword, so the pipe to arm-xlate.pl was never closed
explicitly. Perl could then exit before arm-xlate.pl had written the
output file, and make compiled poly1305-armv9-sve2.S before it existed:
gcc: error: crypto/poly1305/poly1305-armv9-sve2.S: No such file or directory
This was seen on linux-aarch64 builds in the manylinux2014 image
(perl 5.16.3) under QEMU. Running the generator alone 5 times in that
image, the output file was missing right after perl exited 5 times out
of 5; with this change, 0 times out of 5.
The other perlasm scripts, for example poly1305-armv8.pl and
chacha-armv8-sve.pl, already end with "close STDOUT or die ...".
CLA: trivial
Assisted-by: Claude Code:claude-opus-5-5
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
Merge-date: Fri Oct 23 12:49:47 2026
Merged-from: https://github.com/openssl/openssl/pull/33276
| -rwxr-xr-x | crypto/poly1305/asm/poly1305-armv9-sve2.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/poly1305/asm/poly1305-armv9-sve2.pl b/crypto/poly1305/asm/poly1305-armv9-sve2.pl index 1ba59c796d5..aa35299494f 100755 --- a/crypto/poly1305/asm/poly1305-armv9-sve2.pl +++ b/crypto/poly1305/asm/poly1305-armv9-sve2.pl @@ -1418,4 +1418,4 @@ foreach my $line (split("\n",$code)) { } } - STDOUT or die "error closing STDOUT: $!"; +close STDOUT or die "error closing STDOUT: $!"; |
