From 11d83607b8152c77e1175190e42034c5a6f6e77c Mon Sep 17 00:00:00 2001 From: t0kubetsu Date: Tue, 20 Oct 2026 11:00:49 +0200 Subject: poly1305-armv9-sve2.pl: close STDOUT before exiting The last line of the script was " STDOUT or die ...", without the "close" keyword, so the pipe to arm-xlate.pl was never closed explicitly. Perl could then exit before arm-xlate.pl had written the output file, and make compiled poly1305-armv9-sve2.S before it existed: gcc: error: crypto/poly1305/poly1305-armv9-sve2.S: No such file or directory This was seen on linux-aarch64 builds in the manylinux2014 image (perl 5.16.3) under QEMU. Running the generator alone 5 times in that image, the output file was missing right after perl exited 5 times out of 5; with this change, 0 times out of 5. The other perlasm scripts, for example poly1305-armv8.pl and chacha-armv8-sve.pl, already end with "close STDOUT or die ...". CLA: trivial Assisted-by: Claude Code:claude-opus-5-5 Reviewed-by: Shane Lontis Reviewed-by: Tom Cosgrove Merge-date: Fri Oct 23 12:49:47 2026 Merged-from: https://github.com/openssl/openssl/pull/33276 --- crypto/poly1305/asm/poly1305-armv9-sve2.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/poly1305/asm/poly1305-armv9-sve2.pl b/crypto/poly1305/asm/poly1305-armv9-sve2.pl index 1ba59c796d5..aa35299494f 100755 --- a/crypto/poly1305/asm/poly1305-armv9-sve2.pl +++ b/crypto/poly1305/asm/poly1305-armv9-sve2.pl @@ -1418,4 +1418,4 @@ foreach my $line (split("\n",$code)) { } } - STDOUT or die "error closing STDOUT: $!"; +close STDOUT or die "error closing STDOUT: $!"; -- cgit