aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/intel/iwlwifi/fw/error-dump.h
Commit message (Collapse)AuthorAgeFilesLines
* wifi: iwlwifi: debug: set CDB indication from CSRMiri Korenblit2025-05-071-5/+2
| | | | | | | | | | | | | | | | In order to set the CDB indication in the dump meta data, we read it from a specific prph register. There is a known issue with that register in Xnj setups - in that case it will always indicate CDB. Instead of detecting the jacket case and then hardcode whether the CDB indication should or shouldn't be set (according the CRF), we can retrieve the CDB bit from the hw_rf_id (CSR_HW_RF_ID). There is also no reason to do it conditionally only for ax210 / BnJ. Cleanup the code a bit. Reviewed-by: Johannes Berg <[email protected]> Link: https://patch.msgid.link/20250505215513.ea542a6c189e.I3d8cf5103b3747dfdd89985b45b592e419f97b63@changeid Signed-off-by: Miri Korenblit <[email protected]>
* wifi: iwlwifi: fw: fix typo 'adderss'Gan Jie2025-01-131-1/+1
| | | | | | | | | | | Fix typo 'adderss' to 'address'. Signed-off-by: Gan Jie <[email protected]> Link: https://msgid.link/[email protected] Signed-off-by: Miri Korenblit <[email protected]> Reviewed-by: Emmanuel Grumbach <[email protected]> Link: https://patch.msgid.link/20241229164246.ad8978ee5673.I388e314a4be8333192b3994f43efa5dbd3ac715d@changeid Signed-off-by: Johannes Berg <[email protected]>
* wifi: iwlwifi: fix prototype mismatch kernel-doc warningsJohannes Berg2024-06-261-2/+2
| | | | | | | | | | Fix all the prototype mismatch and "wrong kernel-doc identifier" warnings, due to typos in or misformatting of the kernel-doc. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://patch.msgid.link/20240625194805.6ec65cf9b88c.I7804114d7369f352e80a0e8430f7119af8e210de@changeid Signed-off-by: Johannes Berg <[email protected]>
* wifi: iwlwifi: error-dump: fix kernel-doc issuesJohannes Berg2024-02-121-10/+13
| | | | | | | | | | | | Add missing and rename mismatched kernel-doc descriptions. Also just remove the unused IWL_FW_ERROR_DUMP_MAX constant. Signed-off-by: Johannes Berg <[email protected]> Reviewed-by: Miriam Rachel Korenblit <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://msgid.link/20240208185302.b4706117c97b.I5151b055dcf23ccab3ea7cd7d654aeb621cd5119@changeid Signed-off-by: Johannes Berg <[email protected]>
* wifi: iwlwifi: dbg_ini: fix structure packingArnd Bergmann2023-09-111-3/+3
| | | | | | | | | | | | | | | | | | | The iwl_fw_ini_error_dump_range structure has conflicting alignment requirements for the inner union and the outer struct: In file included from drivers/net/wireless/intel/iwlwifi/fw/dbg.c:9: drivers/net/wireless/intel/iwlwifi/fw/error-dump.h:312:2: error: field within 'struct iwl_fw_ini_error_dump_range' is less aligned than 'union iwl_fw_ini_error_dump_range::(anonymous at drivers/net/wireless/intel/iwlwifi/fw/error-dump.h:312:2)' and is usually due to 'struct iwl_fw_ini_error_dump_range' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] union { As the original intention was apparently to make the entire structure unaligned, mark the innermost members the same way so the union becomes packed as well. Fixes: 973193554cae6 ("iwlwifi: dbg_ini: dump headers cleanup") Signed-off-by: Arnd Bergmann <[email protected]> Acked-by: Gregory Greenman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Johannes Berg <[email protected]>
* wifi: iwlwifi: yoyo: Add new tlv for dump file name extensionMukesh Sisodiya2023-03-151-1/+16
| | | | | | | | | Add tlv in dump file for dump file name extension. Signed-off-by: Mukesh Sisodiya <[email protected]> Signed-off-by: Greenman, Gregory <[email protected]> Link: https://lore.kernel.org/r/20230314194113.ffc28212994e.Ie5f10709548497061f95c1634d942dd2facf72ec@changeid Signed-off-by: Johannes Berg <[email protected]>
* iwlwifi: fw: Replace zero-length arrays with flexible-array membersGustavo A. R. Silva2022-04-061-1/+1
| | | | | | | | | | | | | | | | | | There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Kees Cook <[email protected]> Acked-by: Luca Coelho <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/20220216195015.GA904148@embeddedor
* iwlwifi: fw: add support for splitting region type bitsMordechay Goodstein2021-12-071-0/+18
| | | | | | | | | | | | In next region tlv (3) region type is going to be split into bit mask without affecting the ops for handling region type, so we just mask the type independent of the version due to all versions having the same bits usage. Signed-off-by: Mordechay Goodstein <[email protected]> Signed-off-by: Luca Coelho <[email protected]> Link: https://lore.kernel.org/r/iwlwifi.20211204130722.083e4b47055e.If7483d854e3d07f81236d314b8155cd5996f306c@changeid Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: Add support for getting rf id with blank otpMatti Gottlieb2021-10-221-4/+0
| | | | | | | | | | | | | | | When having a blank OTP the only way to get the rf id and the cdb info is from prph registers. Currently there is some implementation for this, but it is located in the wrong place in the code (should be before trying to understand what HW is connected and not after), and it has a partial implementation. Signed-off-by: Matti Gottlieb <[email protected]> Signed-off-by: Luca Coelho <[email protected]> Link: https://lore.kernel.org/r/iwlwifi.20210826224715.820c2ae18c2b.Iec9b2e2615ce65e6aff5ce896589227a7030f4cf@changeid Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: fw: fix debug dump data declarationsJohannes Berg2021-08-261-9/+13
| | | | | | | | | | | | | | | The debug dump ranges aren't just an array of such ranges since each range has a variable size. Therefore, the use of a struct array is misleading at best. Change it to be a u8 data[] instead of the struct array, the code doesn't significantly change since it's actually doing things correctly now. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Luca Coelho <[email protected]> Link: https://lore.kernel.org/r/iwlwifi.20210819183728.693c9891097d.Idcaab1fd659e8be2f56be647b2534befd61a4460@changeid Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: use SPDX tagsJohannes Berg2020-12-091-63/+6
| | | | | | | | | | Use SPDX tags instead of the long copyright notices. Also cleanup some duplicate copyright notices and combine the years where possible. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Luca Coelho <[email protected]> Link: https://lore.kernel.org/r/iwlwifi.20201210000603.481bcb512a6f.I8146abe5a637079e7336209f23cb26af98b12b31@changeid Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg: add dumping special device memoryMordechay Goodstein2020-10-011-0/+14
| | | | | | | | | | | With the new region we can handle in user space understanding the struct type and version and driver doesn't need to be involved at all. Signed-off-by: Mordechay Goodstein <[email protected]> Signed-off-by: Luca Coelho <[email protected]> Link: https://lore.kernel.org/r/iwlwifi.20200926002540.88c431fad7da.I282944cbad5aa367735a9f9a5c47cfbd107a5fc0@changeid Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: differentiate ax210 hw with same hw typeLiad Kaufman2020-05-081-2/+11
| | | | | | | | | | | | | | | There are several "flavors" of HW that have the same HW type, but can be told apart after reading a certain perph register. This is easy to do in runtime, but more complicated to do when looking at the logs offline. To make it easier to tell apart these "flavors" when looking at the dumped dbg info, add these bits to the HW type, allowing simple differentiation. Signed-off-by: Liad Kaufman <[email protected]> Signed-off-by: Luca Coelho <[email protected]> Link: https://lore.kernel.org/r/iwlwifi.20200425130140.330ea11d17ae.Ie59b25430a308090b15112ac6deedf4fbf487ff1@changeid
* iwlwifi: dbg_ini: support FW response/notification region typeShahar S Matityahu2019-10-251-0/+3
| | | | | | | | | Allow the driver to collect FW response/notification region type during dump and allow triggering dump collection for a given FW response/notification. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: use new API in dump infoShahar S Matityahu2019-10-251-16/+20
| | | | | | | | | Make dump info region use new API. debug_info_tlv_list list will be initialize in a future patch once the driver will start using it. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: add error tables dumping supportShahar S Matityahu2019-10-251-0/+11
| | | | | | | Allow to collect error table data. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: add monitor dumping supportShahar S Matityahu2019-10-251-0/+2
| | | | | | | | | | Allow collecting monitor data in ini debug mode. Implement both SMEM and DRAM monitor regions dumping. For DRAM monitor, support DBGC1, DBGC2 and DBGC3 and support several DRAM fragments per DBGC. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: use new trigger TLV in dump flowShahar S Matityahu2019-10-251-6/+5
| | | | | | | Make dump flow use the new trigger TLV. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: fix dump structs docShahar S Matityahu2019-09-061-8/+8
| | | | | | | | Fix the documentation of struct iwl_fw_ini_monitor_dump and iwl_fw_ini_error_dump_range. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: use linked list for dump TLVs during dump creationShahar S Matityahu2019-09-061-0/+22
| | | | | | | | Avoid iterating over dump TLVs twice for size calculation by using linked list to store the dump TLVs. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: implement dump info collectionShahar S Matityahu2019-06-291-0/+62
| | | | | | | | The info struct contains data about the FW, HW, RF and the debug configuration. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: use different barker for ini dumpShahar S Matityahu2019-06-291-3/+1
| | | | | | | | Use a different barker for ini dump to allow differentiation from legacy dump. Also it allows to remove INI_BIT from dump TLVs. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: dump headers cleanupShahar S Matityahu2019-06-291-31/+28
| | | | | | | | | | | | Unite dump memory ranges under a single struct and add a specific header for each type of memory. Also, maintain a single version to all dump structures. This cleanup is also needed for the future addition of FW notification regions and others. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg: replace dump info device family with HW typeShahar S Matityahu2019-04-291-2/+2
| | | | | | | | | | | | | | | | | In the dump info, the driver sets device_family to IWL_FW_ERROR_DUMP_FAMILY_7 in case IWL_FW_ERROR_DUMP_FAMILY_7 is used or IWL_FW_ERROR_DUMP_FAMILY_8 otherwise. This information is misleading and incorrect since the driver sets the device family to 8 to any device that is from family 8 and later, e.g. device family 9 is represented as 8 in the dump. Also, the device family enum is known only to the driver and does not give any information to the FW developer Change the device family to HW type to give propper data about the nic in use. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: add monitor header to smem monitorShahar S Matityahu2019-04-031-3/+3
| | | | | | | Add write pointer and cycle count registers to smem monitor header. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: change memory range base address to u64Shahar S Matityahu2019-04-031-2/+2
| | | | | | | | | | | | AX210 devices will use u64 for the base address to the DRAM monitor buffer. To support this, change the structure for all device families so both address sizes fit. Also move range_data_size to the top of the struct to ease the parsing of the memory range. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: add registers addresses in fifo dumpShahar S Matityahu2019-04-031-2/+13
| | | | | | | Add to the fifo dump the registers addresses. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: add region id to the region dumpShahar S Matityahu2019-04-031-0/+2
| | | | | | | | Add the region id of the collected memory to the header of the memory region. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: add version to dump headerShahar S Matityahu2019-04-031-0/+6
| | | | | | | | | Add version to dump header to allow future changes of the dump struct, once the ini debug flow becomes operational, without breaking backwards compatibility. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg: add DRAM monitor support for AX210 device familyShahar S Matityahu2019-03-221-1/+5
| | | | | | | Allows to perform monitor dumping on AX210 device family Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: implement Rx fifos dumpShahar S Matityahu2019-02-201-0/+3
| | | | | | | Implement Rx fifos dump in the new dump mechanism. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: implement Tx fifos dumpShahar S Matityahu2019-02-201-2/+27
| | | | | | | Implement Tx fifos dump in the new dump mechanism. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: implement monitor dram memory dumpShahar S Matityahu2019-02-141-1/+15
| | | | | | | Implement monitor dram memory dump in the new dump mechanism. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: implement device internal memory dumpShahar S Matityahu2019-02-041-16/+0
| | | | | | | Implement device internal memory dump in the new dump mechanism. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dbg_ini: create new dump flow and implement prph dumpShahar S Matityahu2019-02-041-0/+34
| | | | | | | | Create a skeleton to unite all memory dumps in ini mode. Implement prph dump with the new skeleton. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: Fix pre operational dumping flowsShahar S Matityahu2019-02-041-0/+3
| | | | | | | | | | | | | | | There are several dumping flows in the driver in case of a fail prior to operational. In some cases we get 2 dumps while in others we get none. Fix this by uniting the different flows. Add a different dump type to driver triggered dumps in case we want a dump but did not got assert, and make all dumping go through iwl_fw_dbg_collect_desc to avoid multiple dumps. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: differentiate between alive timeout and alive flow failureShahar S Matityahu2019-02-041-2/+2
| | | | | | | | | | | | | | There are two cases that can cause the alive flow to fail, an assert or a timeout. Currently we mask any incoming asserts when we wait for alive. Solve this by differentiating between the two cases: 1. Let the regular error handling to handle a received assert 2. Do a dump collection in the case of a timeout Signed-off-by: Shahar S Matityahu <[email protected]> Fixes: f38efdb29389 ("iwlwifi: add dump collection in case alive flow fails") Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: wrt: add to dump number of lmacs, lmac1 and umac error idShahar S Matityahu2019-01-251-2/+9
| | | | | | | | | | Add to the dump the number of lmacs, the error id of the umac and the error id of lmac1, if supported. In case the reason for the dump trigger is not an assert the error id is zero. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: wrt: add rt status and num of rx/tx fifos to dumpShahar S Matityahu2018-12-201-0/+3
| | | | | | | | | | Add the rt status of the last assert or 0 if the dump collection was not initiated by an assert. Add the number of rx and tx fifos in use. These fields are added to dump info lst file. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
* iwlwifi: dbg: dump data according to the new ini TLVsSara Sharon2018-12-141-0/+17
| | | | | | | | When ini TLVs are loaded, dump data according to the stored configuration. Signed-off-by: Sara Sharon <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: add dump collection in case alive flow failsShahar S Matityahu2018-10-061-0/+2
| | | | | | | | Trigger dump collection if the alive flow fails, regardless of the reason. Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: add d3 debug data supportShahar S Matityahu2018-08-311-5/+3
| | | | | | | | | During d3, the firmware records debug data into internal buffer if debug data collection occurs, collect the data that was written to the buffer Signed-off-by: Shahar S Matityahu <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: dump smem configuration when firmware crashesGolan Ben-Ami2017-08-091-0/+30
| | | | | | | | | Add the smem configuration to the fw data dump, once the firmware crashes. This is useful mainly for later parsing of the smem. Signed-off-by: Golan Ben-Ami <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
* iwlwifi: create new subdirectory for FW interactionJohannes Berg2017-06-291-0/+335
There's a lot of mvm code that really should be more generic and part of the iwlwifi module. Start by making a place to keep such code - in the new "fw" subdirectory - and already move the firmware related header files there. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
generated by cgit (git 2.51.2) at 2025-12-01 02:13:36 +0000