diff options
| author | Sultan Alsawaf (unemployed) <[email protected]> | 2024-12-12 01:57:32 +0000 |
|---|---|---|
| committer | Rafael J. Wysocki <[email protected]> | 2024-12-18 15:00:29 +0000 |
| commit | 8e461a1cb43d69d2fc8a97e61916dce571e6bb31 (patch) | |
| tree | 36df3037fe210d1833bd73c64c704593b9f0bb36 /tools/testing/selftests/net/lib/py/utils.py | |
| parent | cpufreq: intel_pstate: Use CPUFREQ_POLICY_UNKNOWN (diff) | |
| download | kernel-8e461a1cb43d69d2fc8a97e61916dce571e6bb31.tar.gz kernel-8e461a1cb43d69d2fc8a97e61916dce571e6bb31.zip | |
cpufreq: schedutil: Fix superfluous updates caused by need_freq_update
A redundant frequency update is only truly needed when there is a policy
limits change with a driver that specifies CPUFREQ_NEED_UPDATE_LIMITS.
In spite of that, drivers specifying CPUFREQ_NEED_UPDATE_LIMITS receive a
frequency update _all the time_, not just for a policy limits change,
because need_freq_update is never cleared.
Furthermore, ignore_dl_rate_limit()'s usage of need_freq_update also leads
to a redundant frequency update, regardless of whether or not the driver
specifies CPUFREQ_NEED_UPDATE_LIMITS, when the next chosen frequency is the
same as the current one.
Fix the superfluous updates by only honoring CPUFREQ_NEED_UPDATE_LIMITS
when there's a policy limits change, and clearing need_freq_update when a
requisite redundant update occurs.
This is neatly achieved by moving up the CPUFREQ_NEED_UPDATE_LIMITS test
and instead setting need_freq_update to false in sugov_update_next_freq().
Fixes: 600f5badb78c ("cpufreq: schedutil: Don't skip freq update when limits change")
Signed-off-by: Sultan Alsawaf (unemployed) <[email protected]>
Reviewed-by: Christian Loehle <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Rafael J. Wysocki <[email protected]>
Diffstat (limited to 'tools/testing/selftests/net/lib/py/utils.py')
0 files changed, 0 insertions, 0 deletions
