diff options
| author | Nam Cao <[email protected]> | 2025-04-11 15:09:41 +0000 |
|---|---|---|
| committer | Christian Brauner <[email protected]> | 2025-05-02 12:28:18 +0000 |
| commit | e194d2067c958827810a7a7282dff8773633ad8c (patch) | |
| tree | b73b79dc80797a523c427520b6d31b31e2d953b3 /tools/testing/selftests/coredump/stackdump_test.c | |
| parent | Merge patch series "net, pidfs: enable handing out pidfds for reaped sk->sk_p... (diff) | |
| download | kernel-e194d2067c958827810a7a7282dff8773633ad8c.tar.gz kernel-e194d2067c958827810a7a7282dff8773633ad8c.zip | |
selftests: coredump: Properly initialize pointer
The buffer pointer "line" is not initialized. This pointer is passed to
getline().
It can still work if the stack is zero-initialized, because getline() can
work with a NULL pointer as buffer.
But this is obviously broken. This bug shows up while running the test on a
riscv64 machine.
Fix it by properly initializing the pointer.
Fixes: 15858da53542 ("selftests: coredump: Add stackdump test")
Signed-off-by: Nam Cao <[email protected]>
Link: https://lore.kernel.org/4fb9b6fb3e0040481bacc258c44b4aab5c4df35d.1744383419.git.namcao@linutronix.de
Signed-off-by: Christian Brauner <[email protected]>
Diffstat (limited to 'tools/testing/selftests/coredump/stackdump_test.c')
| -rw-r--r-- | tools/testing/selftests/coredump/stackdump_test.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/testing/selftests/coredump/stackdump_test.c b/tools/testing/selftests/coredump/stackdump_test.c index 137b2364a082..c23cf95c3f6d 100644 --- a/tools/testing/selftests/coredump/stackdump_test.c +++ b/tools/testing/selftests/coredump/stackdump_test.c @@ -138,10 +138,12 @@ TEST_F(coredump, stackdump) ASSERT_NE(file, NULL); /* Step 4: Make sure all stack pointer values are non-zero */ + line = NULL; for (i = 0; -1 != getline(&line, &line_length, file); ++i) { stack = strtoull(line, NULL, 10); ASSERT_NE(stack, 0); } + free(line); ASSERT_EQ(i, 1 + NUM_THREAD_SPAWN); |