diff options
| author | Jose E. Marchesi <[email protected]> | 2024-05-08 10:13:13 +0000 |
|---|---|---|
| committer | Andrii Nakryiko <[email protected]> | 2024-05-08 22:00:55 +0000 |
| commit | 009367099eb61a4fc2af44d4eb06b6b4de7de6db (patch) | |
| tree | fe2af65273e1e7981a195649bf2770c2cac00298 /tools/testing/selftests/bpf/progs/bpf_tracing_net.h | |
| parent | bpf: guard BPF_NO_PRESERVE_ACCESS_INDEX in skb_pkt_end.c (diff) | |
| download | kernel-009367099eb61a4fc2af44d4eb06b6b4de7de6db.tar.gz kernel-009367099eb61a4fc2af44d4eb06b6b4de7de6db.zip | |
bpf: Avoid uninitialized value in BPF_CORE_READ_BITFIELD
[Changes from V1:
- Use a default branch in the switch statement to initialize `val'.]
GCC warns that `val' may be used uninitialized in the
BPF_CRE_READ_BITFIELD macro, defined in bpf_core_read.h as:
[...]
unsigned long long val; \
[...] \
switch (__CORE_RELO(s, field, BYTE_SIZE)) { \
case 1: val = *(const unsigned char *)p; break; \
case 2: val = *(const unsigned short *)p; break; \
case 4: val = *(const unsigned int *)p; break; \
case 8: val = *(const unsigned long long *)p; break; \
} \
[...]
val; \
} \
This patch adds a default entry in the switch statement that sets
`val' to zero in order to avoid the warning, and random values to be
used in case __builtin_preserve_field_info returns unexpected values
for BPF_FIELD_BYTE_SIZE.
Tested in bpf-next master.
No regressions.
Signed-off-by: Jose E. Marchesi <[email protected]>
Signed-off-by: Andrii Nakryiko <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'tools/testing/selftests/bpf/progs/bpf_tracing_net.h')
0 files changed, 0 insertions, 0 deletions
