diff options
| author | Yonghong Song <[email protected]> | 2025-06-07 01:36:26 +0000 |
|---|---|---|
| committer | Alexei Starovoitov <[email protected]> | 2025-06-07 02:21:43 +0000 |
| commit | bbc7bd658ddc662083639b9e9a280b90225ecd9a (patch) | |
| tree | 0e88aec2a0cad7681e72f56a159508a97fb97609 /tools/testing/selftests/bpf/prog_tests/user_ringbuf.c | |
| parent | selftests/bpf: Fix ringbuf/ringbuf_write test failure with arm64 64KB page size (diff) | |
| download | kernel-bbc7bd658ddc662083639b9e9a280b90225ecd9a.tar.gz kernel-bbc7bd658ddc662083639b9e9a280b90225ecd9a.zip | |
selftests/bpf: Fix a user_ringbuf failure with arm64 64KB page size
The ringbuf max_entries must be PAGE_ALIGNED. See kernel function
ringbuf_map_alloc(). So for arm64 64KB page size, adjust max_entries
properly.
Signed-off-by: Yonghong Song <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Alexei Starovoitov <[email protected]>
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/user_ringbuf.c')
| -rw-r--r-- | tools/testing/selftests/bpf/prog_tests/user_ringbuf.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c b/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c index d424e7ecbd12..9fd3ae987321 100644 --- a/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c +++ b/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c @@ -21,8 +21,7 @@ #include "../progs/test_user_ringbuf.h" static const long c_sample_size = sizeof(struct sample) + BPF_RINGBUF_HDR_SZ; -static const long c_ringbuf_size = 1 << 12; /* 1 small page */ -static const long c_max_entries = c_ringbuf_size / c_sample_size; +static long c_ringbuf_size, c_max_entries; static void drain_current_samples(void) { @@ -424,7 +423,9 @@ static void test_user_ringbuf_loop(void) uint32_t remaining_samples = total_samples; int err; - BUILD_BUG_ON(total_samples <= c_max_entries); + if (!ASSERT_LT(c_max_entries, total_samples, "compare_c_max_entries")) + return; + err = load_skel_create_user_ringbuf(&skel, &ringbuf); if (err) return; @@ -686,6 +687,9 @@ void test_user_ringbuf(void) { int i; + c_ringbuf_size = getpagesize(); /* 1 page */ + c_max_entries = c_ringbuf_size / c_sample_size; + for (i = 0; i < ARRAY_SIZE(success_tests); i++) { if (!test__start_subtest(success_tests[i].test_name)) continue; |