diff options
| author | Michael Ellerman <[email protected]> | 2024-08-12 08:26:05 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2024-09-02 03:26:13 +0000 |
| commit | edb4a8bffde725db0c9db2b4a508e01f150dba40 (patch) | |
| tree | 9e7f0e8eaadcb4132a4b48c97150d5233db93d93 /tools/testing/radix-tree/maple.c | |
| parent | mm: remove arch_unmap() (diff) | |
| download | kernel-edb4a8bffde725db0c9db2b4a508e01f150dba40.tar.gz kernel-edb4a8bffde725db0c9db2b4a508e01f150dba40.zip | |
powerpc/vdso: refactor error handling
Linus noticed that the error handling in __arch_setup_additional_pages()
fails to clear the mm VDSO pointer if _install_special_mapping() fails.
In practice there should be no actual bug, because if there's an error the
VDSO pointer is cleared later in arch_setup_additional_pages().
However it's no longer necessary to set the pointer before installing the
mapping. Commit c1bab64360e6 ("powerpc/vdso: Move to
_install_special_mapping() and remove arch_vma_name()") reworked the code
so that the VMA name comes from the vm_special_mapping.name, rather than
relying on arch_vma_name().
So rework the code to only set the VDSO pointer once the mappings have
been installed correctly, and remove the stale comment.
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Michael Ellerman <[email protected]>
Reviewed-by: Liam R. Howlett <[email protected]>
Cc: Christophe Leroy <[email protected]>
Cc: Jeff Xu <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Nicholas Piggin <[email protected]>
Cc: Pedro Falcato <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'tools/testing/radix-tree/maple.c')
0 files changed, 0 insertions, 0 deletions
