aboutsummaryrefslogtreecommitdiffstats
path: root/tools/testing/radix-tree/main.c
diff options
context:
space:
mode:
authorMike Christie <[email protected]>2018-07-26 17:13:49 +0000
committerMatthew Wilcox <[email protected]>2018-08-22 03:54:19 +0000
commit26abc916a898d34c5ad159315a2f683def3c5555 (patch)
tree5cd114e1095b2f698b983a2e121a2627dd4fe618 /tools/testing/radix-tree/main.c
parentdrm/vmwgfx: Convert to new IDA API (diff)
downloadkernel-26abc916a898d34c5ad159315a2f683def3c5555.tar.gz
kernel-26abc916a898d34c5ad159315a2f683def3c5555.zip
iscsi target: fix session creation failure handling
The problem is that iscsi_login_zero_tsih_s1 sets conn->sess early in iscsi_login_set_conn_values. If the function fails later like when we alloc the idr it does kfree(sess) and leaves the conn->sess pointer set. iscsi_login_zero_tsih_s1 then returns -Exyz and we then call iscsi_target_login_sess_out and access the freed memory. This patch has iscsi_login_zero_tsih_s1 either completely setup the session or completely tear it down, so later in iscsi_target_login_sess_out we can just check for it being set to the connection. Cc: [email protected] Fixes: 0957627a9960 ("iscsi-target: Fix sess allocation leak in...") Signed-off-by: Mike Christie <[email protected]> Acked-by: Martin K. Petersen <[email protected]> Signed-off-by: Matthew Wilcox <[email protected]>
Diffstat (limited to 'tools/testing/radix-tree/main.c')
0 files changed, 0 insertions, 0 deletions