aboutsummaryrefslogtreecommitdiffstats
path: root/tools/testing/radix-tree/iteration_check.c
diff options
context:
space:
mode:
authorJan Kara <[email protected]>2016-12-14 23:07:42 +0000
committerLinus Torvalds <[email protected]>2016-12-15 00:04:09 +0000
commita19e25536ed3a20845f642ce531e10c27fb2add5 (patch)
tree7bcc1c969a3138ef3c31c2fb8ae815c96afe4382 /tools/testing/radix-tree/iteration_check.c
parentmm: provide helper for finishing mkwrite faults (diff)
downloadkernel-a19e25536ed3a20845f642ce531e10c27fb2add5.tar.gz
kernel-a19e25536ed3a20845f642ce531e10c27fb2add5.zip
mm: change return values of finish_mkwrite_fault()
Currently finish_mkwrite_fault() returns 0 when PTE got changed before we acquired PTE lock and VM_FAULT_WRITE when we succeeded in modifying the PTE. This is somewhat confusing since 0 generally means success, it is also inconsistent with finish_fault() which returns 0 on success. Change finish_mkwrite_fault() to return 0 on success and VM_FAULT_NOPAGE when PTE changed. Practically, there should be no behavioral difference since we bail out from the fault the same way regardless whether we return 0, VM_FAULT_NOPAGE, or VM_FAULT_WRITE. Also note that VM_FAULT_WRITE has no effect for shared mappings since the only two places that check it - KSM and GUP - care about private mappings only. Generally the meaning of VM_FAULT_WRITE for shared mappings is not well defined and we should probably clean that up. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Jan Kara <[email protected]> Acked-by: Kirill A. Shutemov <[email protected]> Cc: Ross Zwisler <[email protected]> Cc: Dan Williams <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/testing/radix-tree/iteration_check.c')
0 files changed, 0 insertions, 0 deletions