diff options
| author | Ian Rogers <[email protected]> | 2024-01-24 23:42:00 +0000 |
|---|---|---|
| committer | Namhyung Kim <[email protected]> | 2024-01-25 23:22:59 +0000 |
| commit | 24852ef2e2d5c555c2da05baff112ea414b6e0f5 (patch) | |
| tree | 66c4c3dd14305cd313d24659ddca47db50edf6e1 /tools/perf/util/scripting-engines/trace-event-python.c | |
| parent | perf test: Skip test_arm_callgraph_fp.sh if unwinding isn't built in (diff) | |
| download | kernel-24852ef2e2d5c555c2da05baff112ea414b6e0f5.tar.gz kernel-24852ef2e2d5c555c2da05baff112ea414b6e0f5.zip | |
perf pmu: Treat the msr pmu as software
The msr PMU is a software one, meaning msr events may be grouped
with events in a hardware context. As the msr PMU isn't marked as a
software PMU by perf_pmu__is_software, groups with the msr PMU in
are broken and the msr events placed in a different group. This
may lead to multiplexing errors where a hardware event isn't
counted while the msr event, such as tsc, is. Fix all of this by
marking the msr PMU as software, which agrees with the driver.
Before:
```
$ perf stat -e '{slots,tsc}' -a true
WARNING: events were regrouped to match PMUs
Performance counter stats for 'system wide':
1,750,335 slots
4,243,557 tsc
0.001456717 seconds time elapsed
```
After:
```
$ perf stat -e '{slots,tsc}' -a true
Performance counter stats for 'system wide':
12,526,380 slots
3,415,163 tsc
0.001488360 seconds time elapsed
```
Fixes: 251aa040244a ("perf parse-events: Wildcard most "numeric" events")
Signed-off-by: Ian Rogers <[email protected]>
Reviewed-by: Kan Liang <[email protected]>
Cc: James Clark <[email protected]>
Cc: Caleb Biggers <[email protected]>
Cc: Edward Baker <[email protected]>
Cc: Perry Taylor <[email protected]>
Cc: Samantha Alt <[email protected]>
Cc: Weilin Wang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Namhyung Kim <[email protected]>
Diffstat (limited to 'tools/perf/util/scripting-engines/trace-event-python.c')
0 files changed, 0 insertions, 0 deletions
