diff options
| author | Ian Rogers <[email protected]> | 2025-08-23 00:00:24 +0000 |
|---|---|---|
| committer | Namhyung Kim <[email protected]> | 2025-08-25 22:07:18 +0000 |
| commit | 2c369d91d0933aaff96b6b807b22363e6a38a625 (patch) | |
| tree | e22a6006aa6771373c892470e3516da2e2292404 /tools/perf/util/bpf-event.c | |
| parent | perf symbol-minimal: Fix ehdr reading in filename__read_build_id (diff) | |
| download | kernel-2c369d91d0933aaff96b6b807b22363e6a38a625.tar.gz kernel-2c369d91d0933aaff96b6b807b22363e6a38a625.zip | |
perf symbol: Add blocking argument to filename__read_build_id
When synthesizing build-ids, for build ID mmap2 events, they will be
added for data mmaps if -d/--data is specified. The files opened for
their build IDs may block on the open causing perf to hang during
synthesis. There is some robustness in existing calls to
filename__read_build_id by checking the file path is to a regular
file, which unfortunately fails for symlinks. Rather than adding more
is_regular_file calls, switch filename__read_build_id to take a
"block" argument and specify O_NONBLOCK when this is false. The
existing is_regular_file checking callers and the event synthesis
callers are made to pass false and thereby avoiding the hang.
Fixes: 53b00ff358dc ("perf record: Make --buildid-mmap the default")
Signed-off-by: Ian Rogers <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Namhyung Kim <[email protected]>
Diffstat (limited to 'tools/perf/util/bpf-event.c')
0 files changed, 0 insertions, 0 deletions