diff options
| author | NeilBrown <[email protected]> | 2021-02-05 00:36:30 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2021-02-08 18:15:49 +0000 |
| commit | af8085f3a4712c57d0dd415ad543bac85780375c (patch) | |
| tree | 2dbdc0e116d3ae862ff448bdcb434dc3ef8f0757 /tools/perf/util/annotate.c | |
| parent | net: ena: Update XDP verdict upon failure (diff) | |
| download | kernel-af8085f3a4712c57d0dd415ad543bac85780375c.tar.gz kernel-af8085f3a4712c57d0dd415ad543bac85780375c.zip | |
net: fix iteration for sctp transport seq_files
The sctp transport seq_file iterators take a reference to the transport
in the ->start and ->next functions and releases the reference in the
->show function. The preferred handling for such resources is to
release them in the subsequent ->next or ->stop function call.
Since Commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration
code and interface") there is no guarantee that ->show will be called
after ->next, so this function can now leak references.
So move the sctp_transport_put() call to ->next and ->stop.
Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")
Reported-by: Xin Long <[email protected]>
Signed-off-by: NeilBrown <[email protected]>
Acked-by: Marcelo Ricardo Leitner <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'tools/perf/util/annotate.c')
0 files changed, 0 insertions, 0 deletions
