diff options
| author | Arnaldo Carvalho de Melo <[email protected]> | 2019-09-30 18:06:01 +0000 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2019-09-30 20:29:58 +0000 |
| commit | a66fa0619a0ae3585ef09e9c33ecfb5c7c6cb72b (patch) | |
| tree | 5ceee1a3fb603567a7648eaa90d1fb831666de4f /tools/perf/util/annotate.c | |
| parent | perf evsel: Fall back to global 'perf_env' in perf_evsel__env() (diff) | |
| download | kernel-a66fa0619a0ae3585ef09e9c33ecfb5c7c6cb72b.tar.gz kernel-a66fa0619a0ae3585ef09e9c33ecfb5c7c6cb72b.zip | |
perf annotate: Propagate perf_env__arch() error
The callers of symbol__annotate2() use symbol__strerror_disassemble() to
convert its failure returns into a human readable string, so
propagate error values from functions it calls, starting with
perf_env__arch() that when fails the right thing to do is to look at
'errno' to see why its possible call to uname() failed.
Reported-by: Russell King - ARM Linux admin <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>,
Cc: Will Deacon <[email protected]>
Link: https://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/util/annotate.c')
| -rw-r--r-- | tools/perf/util/annotate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index e830eadfca2a..9b7b9176e713 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -2071,7 +2071,7 @@ int symbol__annotate(struct symbol *sym, struct map *map, int err; if (!arch_name) - return -1; + return errno; args.arch = arch = arch__find(arch_name); if (arch == NULL) |