diff options
| author | Arnaldo Carvalho de Melo <[email protected]> | 2019-06-26 18:27:58 +0000 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2019-07-02 01:50:40 +0000 |
| commit | 9c10548c42219e961279826c2763a0e32dc056b9 (patch) | |
| tree | d02eb220dec310ce0bf15c2983940035e2de0efb /tools/perf/util/annotate.c | |
| parent | perf tools: Drop strxfrchar(), use strreplace() equivalent from kernel (diff) | |
| download | kernel-9c10548c42219e961279826c2763a0e32dc056b9.tar.gz kernel-9c10548c42219e961279826c2763a0e32dc056b9.zip | |
tools lib: Move argv_{split,free} from tools/perf/util/
This came from the kernel lib/argv_split.c, so move it to
tools/lib/argv_split.c, to get it closer to the kernel structure.
We need to audit the usage of argv_split() to figure out if it is really
necessary to do have one allocation per argv[] entry, looking at one of
its users I guess that is not the case and we probably are even leaking
those allocations by not using argv_free() judiciously, for later.
With this we further remove stuff from tools/perf/util/, reducing the
perf specific codebase and encouraging other tools/ code to use these
routines so as to keep the style and constructs used with the kernel.
Cc: Adrian Hunter <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Namhyung Kim <[email protected]>
Link: https://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/util/annotate.c')
0 files changed, 0 insertions, 0 deletions