diff options
| author | Arnaldo Carvalho de Melo <[email protected]> | 2019-07-04 15:13:46 +0000 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2019-07-09 13:13:27 +0000 |
| commit | e56fbc9dc79ce0fdc49ffadd062214ddd02f65b6 (patch) | |
| tree | b108e9b4fcb4cc1be29778253097089884b00f23 /tools/perf/ui/gtk/annotate.c | |
| parent | perf tools: Use zfree() where applicable (diff) | |
| download | kernel-e56fbc9dc79ce0fdc49ffadd062214ddd02f65b6.tar.gz kernel-e56fbc9dc79ce0fdc49ffadd062214ddd02f65b6.zip | |
perf tools: Use list_del_init() more thorougly
To allow for destructors to check if they're operating on a object still
in a list, and to avoid going from use after free list entries into
still valid, or even also other already removed from list entries.
Cc: Adrian Hunter <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Link: https://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/ui/gtk/annotate.c')
| -rw-r--r-- | tools/perf/ui/gtk/annotate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/ui/gtk/annotate.c b/tools/perf/ui/gtk/annotate.c index df49c9ba1785..3af87c18a914 100644 --- a/tools/perf/ui/gtk/annotate.c +++ b/tools/perf/ui/gtk/annotate.c @@ -152,7 +152,7 @@ static int perf_gtk__annotate_symbol(GtkWidget *window, struct symbol *sym, gtk_container_add(GTK_CONTAINER(window), view); list_for_each_entry_safe(pos, n, ¬es->src->source, al.node) { - list_del(&pos->al.node); + list_del_init(&pos->al.node); disasm_line__free(pos); } |