diff options
| author | Waiman Long <[email protected]> | 2025-07-29 19:12:32 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2025-08-06 20:48:12 +0000 |
| commit | da274853fe7dbc7124e2dd84dad802be52a09321 (patch) | |
| tree | 768ad272f5b3384230345ce5313acc84ef0822dd /tools/perf/ui/browsers/annotate.c | |
| parent | smp: Fix spelling in on_each_cpu_cond_mask()'s doc-comment (diff) | |
| download | kernel-da274853fe7dbc7124e2dd84dad802be52a09321.tar.gz kernel-da274853fe7dbc7124e2dd84dad802be52a09321.zip | |
cpu: Remove obsolete comment from takedown_cpu()
takedown_cpu() has a comment about "all preempt/rcu users must observe
!cpu_active()" which is kind of meaningless in this function. This
comment was originally introduced by commit 6acce3ef8452 ("sched: Remove
get_online_cpus() usage") when _cpu_down() was setting cpu_active_mask
and synchronize_rcu()/synchronize_sched() were added after that.
Later commit 40190a78f85f ("sched/hotplug: Convert cpu_[in]active
notifiers to state machine") added a new CPUHP_AP_ACTIVE hotplug
state to set/clear cpu_active_mask. The following commit b2454caa8977
("sched/hotplug: Move sync_rcu to be with set_cpu_active(false)")
move the synchronize_*() calls to sched_cpu_deactivate() associated
with the new hotplug state, but left the comment behind.
Remove this comment as it is no longer relevant in takedown_cpu().
Signed-off-by: Waiman Long <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/all/[email protected]
Diffstat (limited to 'tools/perf/ui/browsers/annotate.c')
0 files changed, 0 insertions, 0 deletions