aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/ui/browsers/annotate.c
diff options
context:
space:
mode:
authorIngo Molnar <[email protected]>2016-10-04 07:55:57 +0000
committerIngo Molnar <[email protected]>2016-10-04 07:55:57 +0000
commitbe6a2e4c46cc122ba9113ba569fbc50fad075fff (patch)
treeee35fb58cc7d610b22cb2792eef18b5a813f018c /tools/perf/ui/browsers/annotate.c
parentMerge branch 'smp-hotplug-for-linus' of git://git.kernel.org/pub/scm/linux/ke... (diff)
downloadkernel-be6a2e4c46cc122ba9113ba569fbc50fad075fff.tar.gz
kernel-be6a2e4c46cc122ba9113ba569fbc50fad075fff.zip
Revert "sched/core: Do not use smp_processor_id() with preempt enabled in smpboot_thread_fn()"
This reverts commit 4fa5cd5245b627db88c9ca08ae442373b02596b4. The original change widens a preempt-off section, to avoid a seemingly unsafe smp_processor_id() use. During review I overlooked two facts: - The code to calls a non-trivial function callback: ht->park(td->cpu); ... which might (and does occasionally) sleep, triggering the warning. - More importantly, as pointed out by Peter Zijlstra, using smp_processor_id() in that context is safe, if it's done from a kernel thread that is pinned to a single CPU - which is the case here. So revert to the original code that enables preemption sooner. Reported-by: kernel test robot <[email protected]> Acked-by: Peter Zijlstra <[email protected]> Cc: Con Kolivas <[email protected]> Cc: Alfred Chen <[email protected]> Link: http://lkml.kernel.org/r/20160930015102.GB20189@yexl-desktop Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'tools/perf/ui/browsers/annotate.c')
0 files changed, 0 insertions, 0 deletions