aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/ui/browsers/annotate-data.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <[email protected]>2024-05-07 03:04:06 +0000
committerArnaldo Carvalho de Melo <[email protected]>2024-05-07 15:43:53 +0000
commit69fb6eab1969d09187feff14f370e01032054f1f (patch)
treee78dd2e83d3ef5fcce59aaaeae4af867e1232e02 /tools/perf/ui/browsers/annotate-data.c
parentperf dso: Use container_of() to avoid a pointer in 'struct dso_data' (diff)
downloadkernel-69fb6eab1969d09187feff14f370e01032054f1f.tar.gz
kernel-69fb6eab1969d09187feff14f370e01032054f1f.zip
perf annotate: Use zfree() to avoid possibly accessing dangling pointers
When freeing a->b it is good practice to set a->b to NULL using zfree(&a->b) so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to use a->b. This is mostly done but some new cases were introduced recently, convert them to zfree(). Cc: Adrian Hunter <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Kan Liang <[email protected]> Cc: Namhyung Kim <[email protected]> Link: https://lore.kernel.org/lkml/ZjmbHHrjIm5YRIBv@x1 Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/ui/browsers/annotate-data.c')
-rw-r--r--tools/perf/ui/browsers/annotate-data.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/ui/browsers/annotate-data.c b/tools/perf/ui/browsers/annotate-data.c
index a4a0f042f201..8d6bf08d371d 100644
--- a/tools/perf/ui/browsers/annotate-data.c
+++ b/tools/perf/ui/browsers/annotate-data.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#include <inttypes.h>
#include <string.h>
+#include <linux/zalloc.h>
#include <sys/ttydefaults.h>
#include "ui/browser.h"
@@ -130,7 +131,7 @@ static void annotated_data_browser__delete_entries(struct annotated_data_browser
list_for_each_entry_safe(pos, tmp, &browser->entries, node) {
list_del_init(&pos->node);
- free(pos->hists);
+ zfree(&pos->hists);
free(pos);
}
}