diff options
| author | Ian Rogers <[email protected]> | 2025-01-13 19:43:45 +0000 |
|---|---|---|
| committer | Namhyung Kim <[email protected]> | 2025-02-13 04:06:11 +0000 |
| commit | dc6d2bc2d893a878e7b58578ff01b4738708deb4 (patch) | |
| tree | b5524ff4429f1e88533f518753091462bc4bd8b4 /tools/perf/tests/openat-syscall-tp-fields.c | |
| parent | perf test stat_all_metrics: Ensure missing events fail test (diff) | |
| download | kernel-dc6d2bc2d893a878e7b58578ff01b4738708deb4.tar.gz kernel-dc6d2bc2d893a878e7b58578ff01b4738708deb4.zip | |
perf sample: Make user_regs and intr_regs optional
The struct dump_regs contains 512 bytes of cache_regs, meaning the two
values in perf_sample contribute 1088 bytes of its total 1384 bytes
size. Initializing this much memory has a cost reported by Tavian
Barnes <[email protected]> as about 2.5% when running `perf
script --itrace=i0`:
https://lore.kernel.org/lkml/d841b97b3ad2ca8bcab07e4293375fb7c32dfce7.1736618095.git.tavianator@tavianator.com/
Adrian Hunter <[email protected]> replied that the zero
initialization was necessary and couldn't simply be removed.
This patch aims to strike a middle ground of still zeroing the
perf_sample, but removing 79% of its size by make user_regs and
intr_regs optional pointers to zalloc-ed memory. To support the
allocation accessors are created for user_regs and intr_regs. To
support correct cleanup perf_sample__init and perf_sample__exit
functions are created and added throughout the code base.
Signed-off-by: Ian Rogers <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Namhyung Kim <[email protected]>
Diffstat (limited to 'tools/perf/tests/openat-syscall-tp-fields.c')
| -rw-r--r-- | tools/perf/tests/openat-syscall-tp-fields.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/perf/tests/openat-syscall-tp-fields.c b/tools/perf/tests/openat-syscall-tp-fields.c index 3943da441979..0ef4ba7c1571 100644 --- a/tools/perf/tests/openat-syscall-tp-fields.c +++ b/tools/perf/tests/openat-syscall-tp-fields.c @@ -111,14 +111,16 @@ static int test__syscall_openat_tp_fields(struct test_suite *test __maybe_unused continue; } + perf_sample__init(&sample, /*all=*/false); err = evsel__parse_sample(evsel, event, &sample); if (err) { pr_debug("Can't parse sample, err = %d\n", err); + perf_sample__exit(&sample); goto out_delete_evlist; } tp_flags = evsel__intval(evsel, &sample, "flags"); - + perf_sample__exit(&sample); if (flags != tp_flags) { pr_debug("%s: Expected flags=%#x, got %#x\n", __func__, flags, tp_flags); |