aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/tests/bpf-script-example.c
diff options
context:
space:
mode:
authorTejun Heo <[email protected]>2023-01-06 20:34:10 +0000
committerJens Axboe <[email protected]>2023-01-09 03:29:28 +0000
commit49e4d04f0486117ac57a97890eb1db6d52bf82b3 (patch)
tree52c23d13e213ebcd383684c739d1c7a81cce5464 /tools/perf/tests/bpf-script-example.c
parentblock: Remove "select SRCU" (diff)
downloadkernel-49e4d04f0486117ac57a97890eb1db6d52bf82b3.tar.gz
kernel-49e4d04f0486117ac57a97890eb1db6d52bf82b3.zip
block: Drop spurious might_sleep() from blk_put_queue()
Dan reports the following smatch detected the following: block/blk-cgroup.c:1863 blkcg_schedule_throttle() warn: sleeping in atomic context caused by blkcg_schedule_throttle() calling blk_put_queue() in an non-sleepable context. blk_put_queue() acquired might_sleep() in 63f93fd6fa57 ("block: mark blk_put_queue as potentially blocking") which transferred the might_sleep() from blk_free_queue(). blk_free_queue() acquired might_sleep() in e8c7d14ac6c3 ("block: revert back to synchronous request_queue removal") while turning request_queue removal synchronous. However, this isn't necessary as nothing in the free path actually requires sleeping. It's pretty unusual to require a sleeping context in a put operation and it's not needed in the first place. Let's drop it. Signed-off-by: Tejun Heo <[email protected]> Reported-by: Dan Carpenter <[email protected]> Link: https://lkml.kernel.org/r/Y7g3L6fntnTtOm63@kili Cc: Christoph Hellwig <[email protected]> Cc: Luis Chamberlain <[email protected]> Fixes: e8c7d14ac6c3 ("block: revert back to synchronous request_queue removal") # v5.9+ Reviewed-by: Christoph Hellwig <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'tools/perf/tests/bpf-script-example.c')
0 files changed, 0 insertions, 0 deletions