diff options
| author | Amol Grover <[email protected]> | 2020-01-18 16:54:18 +0000 |
|---|---|---|
| committer | Paul E. McKenney <[email protected]> | 2020-02-20 23:58:23 +0000 |
| commit | 4dfd5cd83dc4458049c7f6eb9c4f361acc4239ea (patch) | |
| tree | 77997758f8b5f1d2a6615c69428ab57d74738040 /tools/perf/scripts/python/sctop.py | |
| parent | rcu: Fix rcu_barrier_callback() race condition (diff) | |
| download | kernel-4dfd5cd83dc4458049c7f6eb9c4f361acc4239ea.tar.gz kernel-4dfd5cd83dc4458049c7f6eb9c4f361acc4239ea.zip | |
rculist: Add brackets around cond argument in __list_check_rcu macro
Passing a complex lockdep condition to __list_check_rcu results
in false positive lockdep splat due to incorrect expression
evaluation.
For example, a lockdep check condition `cond1 || cond2` is
evaluated as `!cond1 || cond2 && !rcu_read_lock_any_held()`
which, according to operator precedence, evaluates to
`!cond1 || (cond2 && !rcu_read_lock_any_held())`.
This would result in a lockdep splat when cond1 is false
and cond2 is true which is logically incorrect.
Signed-off-by: Amol Grover <[email protected]>
Acked-by: Joel Fernandes (Google) <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/sctop.py')
0 files changed, 0 insertions, 0 deletions