diff options
| author | Hawkins Jiawei <[email protected]> | 2023-08-10 11:04:05 +0000 |
|---|---|---|
| committer | Michael S. Tsirkin <[email protected]> | 2023-08-10 19:51:45 +0000 |
| commit | 2c507ce90e02cd78d00fd4b0fe26c8641873c13f (patch) | |
| tree | d14eacf902c77a03db7975c3c72f2f3f8aae5196 /tools/perf/scripts/python/sctop.py | |
| parent | vdpa/mlx5: Fix crash on shutdown for when no ndev exists (diff) | |
| download | kernel-2c507ce90e02cd78d00fd4b0fe26c8641873c13f.tar.gz kernel-2c507ce90e02cd78d00fd4b0fe26c8641873c13f.zip | |
virtio-net: Zero max_tx_vq field for VIRTIO_NET_CTRL_MQ_HASH_CONFIG case
Kernel uses `struct virtio_net_ctrl_rss` to save command-specific-data
for both the VIRTIO_NET_CTRL_MQ_HASH_CONFIG and
VIRTIO_NET_CTRL_MQ_RSS_CONFIG commands.
According to the VirtIO standard, "Field reserved MUST contain zeroes.
It is defined to make the structure to match the layout of
virtio_net_rss_config structure, defined in 5.1.6.5.7.".
Yet for the VIRTIO_NET_CTRL_MQ_HASH_CONFIG command case, the `max_tx_vq`
field in struct virtio_net_ctrl_rss, which corresponds to the
`reserved` field in struct virtio_net_hash_config, is not zeroed,
thereby violating the VirtIO standard.
This patch solves this problem by zeroing this field in
virtnet_init_default_rss().
Cc: Andrew Melnychenko <[email protected]>
Cc: [email protected]
Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.")
Signed-off-by: Hawkins Jiawei <[email protected]>
Acked-by: Jason Wang <[email protected]>
Acked-by: Eugenio Pérez <[email protected]>
Acked-by: Michael S. Tsirkin <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Xuan Zhuo <[email protected]>
Acked-by: Jason Wang <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/sctop.py')
0 files changed, 0 insertions, 0 deletions
