diff options
| author | Daniel Borkmann <[email protected]> | 2018-08-08 17:23:13 +0000 |
|---|---|---|
| committer | Alexei Starovoitov <[email protected]> | 2018-08-08 19:06:17 +0000 |
| commit | 5121700b346b6160ccc9411194e3f1f417c340d1 (patch) | |
| tree | 519bc8a547f5550b747006fefc61f0c120196164 /tools/perf/scripts/python/intel-pt-events.py | |
| parent | bpf: btf: Change tools/lib/bpf/btf to LGPL (diff) | |
| download | kernel-5121700b346b6160ccc9411194e3f1f417c340d1.tar.gz kernel-5121700b346b6160ccc9411194e3f1f417c340d1.zip | |
bpf, sockmap: fix bpf_tcp_sendmsg sock error handling
While working on bpf_tcp_sendmsg() code, I noticed that when a
sk->sk_err is set we error out with err = sk->sk_err. However
this is problematic since sk->sk_err is a positive error value
and therefore we will neither go into sk_stream_error() nor will
we report an error back to user space. I had this case with EPIPE
and user space was thinking sendmsg() succeeded since EPIPE is
a positive value, thinking we submitted 32 bytes. Fix it by
negating the sk->sk_err value.
Fixes: 4f738adba30a ("bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data")
Signed-off-by: Daniel Borkmann <[email protected]>
Acked-by: John Fastabend <[email protected]>
Signed-off-by: Alexei Starovoitov <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/intel-pt-events.py')
0 files changed, 0 insertions, 0 deletions