diff options
| author | Uwe Kleine-König <[email protected]> | 2023-03-21 08:41:16 +0000 |
|---|---|---|
| committer | Joerg Roedel <[email protected]> | 2023-03-31 08:01:55 +0000 |
| commit | a2972cb89935160bfe515b15d28a77694723ac06 (patch) | |
| tree | a50218a6fef6a97298e8f62d8bde9874d8c9992e /tools/perf/scripts/python/flamegraph.py | |
| parent | Linux 6.3-rc3 (diff) | |
| download | kernel-a2972cb89935160bfe515b15d28a77694723ac06.tar.gz kernel-a2972cb89935160bfe515b15d28a77694723ac06.zip | |
iommu/arm-smmu: Drop if with an always false condition
The remove and shutdown callback are only called after probe completed
successfully. In this case platform_set_drvdata() was called with a
non-NULL argument and so smmu is never NULL. Other functions in this
driver also don't check for smmu being non-NULL before using it.
Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm allocated
resources are freed (among others *smmu and the register mapping). So
after an early exit to iommu device stayed around and using it probably
oopses.
Signed-off-by: Uwe Kleine-König <[email protected]>
Reviewed-by: Robin Murphy <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Joerg Roedel <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/flamegraph.py')
0 files changed, 0 insertions, 0 deletions
