diff options
| author | Xiyu Yang <[email protected]> | 2020-04-20 05:35:28 +0000 |
|---|---|---|
| committer | John Johansen <[email protected]> | 2020-05-21 22:25:51 +0000 |
| commit | c6b39f070722ea9963ffe756bfe94e89218c5e63 (patch) | |
| tree | 5c8de2d138cd172138ab19c204884366960a6f55 /tools/perf/scripts/python/event_analyzing_sample.py | |
| parent | apparmor: fix potential label refcnt leak in aa_change_profile (diff) | |
| download | kernel-c6b39f070722ea9963ffe756bfe94e89218c5e63.tar.gz kernel-c6b39f070722ea9963ffe756bfe94e89218c5e63.zip | |
apparmor: Fix aa_label refcnt leak in policy_update
policy_update() invokes begin_current_label_crit_section(), which
returns a reference of the updated aa_label object to "label" with
increased refcount.
When policy_update() returns, "label" becomes invalid, so the refcount
should be decreased to keep refcount balanced.
The reference counting issue happens in one exception handling path of
policy_update(). When aa_may_manage_policy() returns not NULL, the
refcnt increased by begin_current_label_crit_section() is not decreased,
causing a refcnt leak.
Fix this issue by jumping to "end_section" label when
aa_may_manage_policy() returns not NULL.
Fixes: 5ac8c355ae00 ("apparmor: allow introspecting the loaded policy pre internal transform")
Signed-off-by: Xiyu Yang <[email protected]>
Signed-off-by: Xin Tan <[email protected]>
Signed-off-by: John Johansen <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/event_analyzing_sample.py')
0 files changed, 0 insertions, 0 deletions