aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/scripts/python/compaction-times.py
diff options
context:
space:
mode:
authorYu Kuai <[email protected]>2023-08-16 01:27:08 +0000
committerJens Axboe <[email protected]>2023-08-30 16:15:01 +0000
commiteead0056648cef49d7b15c07ae612fa217083165 (patch)
tree5945d041f446ea086d237697ba969079d07d6082 /tools/perf/scripts/python/compaction-times.py
parentblk-throttle: use calculate_io/bytes_allowed() for throtl_trim_slice() (diff)
downloadkernel-eead0056648cef49d7b15c07ae612fa217083165.tar.gz
kernel-eead0056648cef49d7b15c07ae612fa217083165.zip
blk-throttle: consider 'carryover_ios/bytes' in throtl_trim_slice()
Currently, 'carryover_ios/bytes' is not handled in throtl_trim_slice(), for consequence, 'carryover_ios/bytes' will be used to throttle bio multiple times, for example: 1) set iops limit to 100, and slice start is 0, slice end is 100ms; 2) current time is 0, and 10 ios are dispatched, those io won't be throttled and io_disp is 10; 3) still at current time 0, update iops limit to 1000, carryover_ios is updated to (0 - 10) = -10; 4) in this slice(0 - 100ms), io_allowed = 100 + (-10) = 90, which means only 90 ios can be dispatched without waiting; 5) assume that io is throttled in slice(0 - 100ms), and throtl_trim_slice() update silce to (100ms - 200ms). In this case, 'carryover_ios/bytes' is not cleared and still only 90 ios can be dispatched between 100ms - 200ms. Fix this problem by updating 'carryover_ios/bytes' in throtl_trim_slice(). Fixes: a880ae93e5b5 ("blk-throttle: fix io hung due to configuration updates") Reported-by: zhuxiaohui <[email protected]> Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Yu Kuai <[email protected]> Acked-by: Tejun Heo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/compaction-times.py')
0 files changed, 0 insertions, 0 deletions