diff options
| author | NeilBrown <[email protected]> | 2022-10-09 23:26:51 +0000 |
|---|---|---|
| committer | Trond Myklebust <[email protected]> | 2022-12-06 15:45:11 +0000 |
| commit | ef8d98f20dfc79777d2b66a30926533225dc6efa (patch) | |
| tree | 045d63568aabe0c9fb21918cbbe22035fe870fde /tools/perf/scripts/python/check-perf-trace.py | |
| parent | nfs: fix possible null-ptr-deref when parsing param (diff) | |
| download | kernel-ef8d98f20dfc79777d2b66a30926533225dc6efa.tar.gz kernel-ef8d98f20dfc79777d2b66a30926533225dc6efa.zip | |
NFS: avoid spurious warning of lost lock that is being unlocked.
When the NFSv4 state manager recovers state after a server restart, it
reports that locks have been lost if it finds any lock state for which
recovery hasn't been successful. i.e. any for which
NFS_LOCK_INITIALIZED is not set.
However it only tries to recover locks that are still linked to
inode->i_flctx. So if a lock has been removed from inode->i_flctx, but
the state for that lock has not yet been destroyed, then a spurious
warning results.
nfs4_proc_unlck() calls locks_lock_inode_wait() - which removes the lock
from ->i_flctx - before sending the unlock request to the server and
before the final nfs4_put_lock_state() is called. This allows a window
in which a spurious warning can be produced.
So add a new flag NFS_LOCK_UNLOCKING which is set once the decision has
been made to unlock the lock. This will prevent it from triggering any
warning.
Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/check-perf-trace.py')
0 files changed, 0 insertions, 0 deletions
