diff options
| author | Shuchang Li <[email protected]> | 2023-04-04 07:21:32 +0000 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2023-04-12 01:03:00 +0000 |
| commit | 91a0c0c1413239d0548b5aac4c82f38f6d53a91e (patch) | |
| tree | bd0cb7e508d533966101194348d71a291ff05ea3 /tools/perf/scripts/python/check-perf-trace.py | |
| parent | scsi: mpt3sas: Fix an issue when driver is being removed (diff) | |
| download | kernel-91a0c0c1413239d0548b5aac4c82f38f6d53a91e.tar.gz kernel-91a0c0c1413239d0548b5aac4c82f38f6d53a91e.zip | |
scsi: lpfc: Fix ioremap issues in lpfc_sli4_pci_mem_setup()
When if_type equals zero and pci_resource_start(pdev, PCI_64BIT_BAR4)
returns false, drbl_regs_memmap_p is not remapped. This passes a NULL
pointer to iounmap(), which can trigger a WARN() on certain arches.
When if_type equals six and pci_resource_start(pdev, PCI_64BIT_BAR4)
returns true, drbl_regs_memmap_p may has been remapped and
ctrl_regs_memmap_p is not remapped. This is a resource leak and passes a
NULL pointer to iounmap().
To fix these issues, we need to add null checks before iounmap(), and
change some goto labels.
Fixes: 1351e69fc6db ("scsi: lpfc: Add push-to-adapter support to sli4")
Signed-off-by: Shuchang Li <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Justin Tee <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/check-perf-trace.py')
0 files changed, 0 insertions, 0 deletions