diff options
| author | Xiao Ni <[email protected]> | 2018-08-30 07:57:09 +0000 |
|---|---|---|
| committer | Shaohua Li <[email protected]> | 2018-09-01 00:38:10 +0000 |
| commit | 1d0ffd264204eba1861865560f1f7f7a92919384 (patch) | |
| tree | 0001aaa48ec025480a9057d4d9c6763cc1e23e64 /tools/perf/scripts/python/bin/export-to-postgresql-report | |
| parent | md/raid5-cache: disable reshape completely (diff) | |
| download | kernel-1d0ffd264204eba1861865560f1f7f7a92919384.tar.gz kernel-1d0ffd264204eba1861865560f1f7f7a92919384.zip | |
RAID10 BUG_ON in raise_barrier when force is true and conf->barrier is 0
In raid10 reshape_request it gets max_sectors in read_balance. If the underlayer disks
have bad blocks, the max_sectors is less than last. It will call goto read_more many
times. It calls raise_barrier(conf, sectors_done != 0) every time. In this condition
sectors_done is not 0. So the value passed to the argument force of raise_barrier is
true.
In raise_barrier it checks conf->barrier when force is true. If force is true and
conf->barrier is 0, it panic. In this case reshape_request submits bio to under layer
disks. And in the callback function of the bio it calls lower_barrier. If the bio
finishes before calling raise_barrier again, it can trigger the BUG_ON.
Add one pair of raise_barrier/lower_barrier to fix this bug.
Signed-off-by: Xiao Ni <[email protected]>
Suggested-by: Neil Brown <[email protected]>
Signed-off-by: Shaohua Li <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/bin/export-to-postgresql-report')
0 files changed, 0 insertions, 0 deletions