diff options
| author | Ming Lei <[email protected]> | 2023-09-01 13:49:16 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2023-09-01 13:54:06 +0000 |
| commit | b484a40dc1f16edb58e5430105a021e1916e6f27 (patch) | |
| tree | 83d03fb7a8cacab3b52f3b707def4a7960ff2894 /tools/perf/builtin-script.c | |
| parent | io_uring: Don't set affinity on a dying sqpoll thread (diff) | |
| download | kernel-b484a40dc1f16edb58e5430105a021e1916e6f27.tar.gz kernel-b484a40dc1f16edb58e5430105a021e1916e6f27.zip | |
io_uring: fix IO hang in io_wq_put_and_exit from do_exit()
io_wq_put_and_exit() is called from do_exit(), but all FIXED_FILE requests
in io_wq aren't canceled in io_uring_cancel_generic() called from do_exit().
Meantime io_wq IO code path may share resource with normal iopoll code
path.
So if any HIPRI request is submittd via io_wq, this request may not get resouce
for moving on, given iopoll isn't possible in io_wq_put_and_exit().
The issue can be triggered when terminating 't/io_uring -n4 /dev/nullb0'
with default null_blk parameters.
Fix it by always cancelling all requests in io_wq by adding helper of
io_uring_cancel_wq(), and this way is reasonable because io_wq destroying
follows canceling requests immediately.
Closes: https://lore.kernel.org/linux-block/[email protected]/
Reported-by: David Howells <[email protected]>
Cc: Chengming Zhou <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'tools/perf/builtin-script.c')
0 files changed, 0 insertions, 0 deletions
