aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-script.c
diff options
context:
space:
mode:
authorNamhyung Kim <[email protected]>2024-08-12 17:25:33 +0000
committerArnaldo Carvalho de Melo <[email protected]>2024-08-12 21:04:35 +0000
commit040c0f887fdcfe747a3f63c94e9cd29e9ed0b872 (patch)
tree32b542de45eb605679a26a4fd4e03eea4b2afeb6 /tools/perf/builtin-script.c
parentperf annotate-data: Fix a buffer overflow in TUI browser (diff)
downloadkernel-040c0f887fdcfe747a3f63c94e9cd29e9ed0b872.tar.gz
kernel-040c0f887fdcfe747a3f63c94e9cd29e9ed0b872.zip
perf lock contention: Change stack_id type to s32
The bpf_get_stackid() helper returns a signed type to check whether it failed to get a stacktrace or not. But it saved the result in u32 and checked if the value is negative. 376 if (needs_callstack) { 377 pelem->stack_id = bpf_get_stackid(ctx, &stacks, 378 BPF_F_FAST_STACK_CMP | stack_skip); --> 379 if (pelem->stack_id < 0) ./tools/perf/util/bpf_skel/lock_contention.bpf.c:379 contention_begin() warn: unsigned 'pelem->stack_id' is never less than zero. Let's change the type to s32 instead. Fixes: 6d499a6b3d90277d ("perf lock: Print the number of lost entries for BPF") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Namhyung Kim <[email protected]> Cc: Adrian Hunter <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Kan Liang <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/builtin-script.c')
0 files changed, 0 insertions, 0 deletions