diff options
| author | Namhyung Kim <[email protected]> | 2024-04-25 00:51:57 +0000 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2024-04-27 01:12:55 +0000 |
| commit | 8f3ec810bb668d421f9d260e3de3bccca954b56f (patch) | |
| tree | ae220ab6c776ce65ad7b6e9305df375abf5b568e /tools/perf/builtin-annotate.c | |
| parent | perf annotate: Fallback disassemble to objdump when capstone fails (diff) | |
| download | kernel-8f3ec810bb668d421f9d260e3de3bccca954b56f.tar.gz kernel-8f3ec810bb668d421f9d260e3de3bccca954b56f.zip | |
perf annotate: Update DSO binary type when trying build-id
dso__disassemble_filename() tries to get the filename for objdump (or
capstone) using build-id. But I found sometimes it didn't disassemble
some functions.
It turned out that those functions belong to a DSO which has no binary
type set. It seems it sets the binary type for some special files only
- like kernel (kallsyms or kcore) or BPF images. And there's a logic to
skip dso with DSO_BINARY_TYPE__NOT_FOUND.
As it's checked the build-id cache link, it should set the binary type
as DSO_BINARY_TYPE__BUILD_ID_CACHE.
Fixes: 873a83731f1cc85c ("perf annotate: Skip DSOs not found")
Signed-off-by: Namhyung Kim <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Kan Liang <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
0 files changed, 0 insertions, 0 deletions
