aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-annotate.c
diff options
context:
space:
mode:
authorIan Rogers <[email protected]>2021-12-23 18:56:22 +0000
committerArnaldo Carvalho de Melo <[email protected]>2022-02-15 20:15:33 +0000
commit87a73bdc421ac702c248002a0a2e62f08c6e7682 (patch)
tree017df856afa33bc346462b180a243c15f0cbf9b6 /tools/perf/builtin-annotate.c
parentperf cs-etm: Update deduction of TRCCONFIGR register for branch broadcast (diff)
downloadkernel-87a73bdc421ac702c248002a0a2e62f08c6e7682.tar.gz
kernel-87a73bdc421ac702c248002a0a2e62f08c6e7682.zip
perf test: Make metric testing more robust
When testing metric expressions we fake counter values from 1 going upward. For some metrics this can yield negative values that are clipped to zero, and then cause divide by zero failures. Such clipping is questionable but may be a result of tools automatically generating metrics. A workaround for this case is to try a second time with counter values going in the opposite direction. This case was seen in a metric like: event1 / max(event2 - event3, 0) But it may also happen in more sensible metrics like: event1 / (event2 + event3 - 1 - event4) Reviewed-by: John Garry <[email protected]> Signed-off-by: Ian Rogers <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Kajol Jain <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Stephane Eranian <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
0 files changed, 0 insertions, 0 deletions