diff options
| author | Krzysztof Kozlowski <[email protected]> | 2025-06-18 07:36:50 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2025-06-19 15:33:54 +0000 |
| commit | fc27ab48904ceb7e4792f0c400f1ef175edf16fe (patch) | |
| tree | 451561d1bdd3594c17049c3bdf68be862a9bb3ba /tools/net/ynl/pyynl/lib/ynl.py | |
| parent | calipso: Fix null-ptr-deref in calipso_req_{set,del}attr(). (diff) | |
| download | kernel-fc27ab48904ceb7e4792f0c400f1ef175edf16fe.tar.gz kernel-fc27ab48904ceb7e4792f0c400f1ef175edf16fe.zip | |
NFC: nci: uart: Set tty->disc_data only in success path
Setting tty->disc_data before opening the NCI device means we need to
clean it up on error paths. This also opens some short window if device
starts sending data, even before NCIUARTSETDRIVER IOCTL succeeded
(broken hardware?). Close the window by exposing tty->disc_data only on
the success path, when opening of the NCI device and try_module_get()
succeeds.
The code differs in error path in one aspect: tty->disc_data won't be
ever assigned thus NULL-ified. This however should not be relevant
difference, because of "tty->disc_data=NULL" in nci_uart_tty_open().
Cc: Linus Torvalds <[email protected]>
Fixes: 9961127d4bce ("NFC: nci: add generic uart support")
Cc: <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Greg Kroah-Hartman <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'tools/net/ynl/pyynl/lib/ynl.py')
0 files changed, 0 insertions, 0 deletions