diff options
| author | Jin Yao <[email protected]> | 2019-12-20 01:37:19 +0000 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2019-12-20 21:49:27 +0000 |
| commit | 0feba17bd7ee3b7e03d141f119049dcc23efa94e (patch) | |
| tree | 5c63acd22c41f81939a169e15e0446fe434c9c6f /tools/lib/perf/threadmap.c | |
| parent | tools lib traceevent: Fix memory leakage in filter_event (diff) | |
| download | kernel-0feba17bd7ee3b7e03d141f119049dcc23efa94e.tar.gz kernel-0feba17bd7ee3b7e03d141f119049dcc23efa94e.zip | |
perf report: Fix incorrectly added dimensions as switch perf data file
We observed an issue that was some extra columns displayed after switching
perf data file in browser. The steps to reproduce:
1. perf record -a -e cycles,instructions -- sleep 3
2. perf report --group
3. In browser, we use hotkey 's' to switch to another perf.data
4. Now in browser, the extra columns 'Self' and 'Children' are displayed.
The issue is setup_sorting() executed again after repeat path, so dimensions
are added again.
This patch checks the last key returned from __cmd_report(). If it's
K_SWITCH_INPUT_DATA, skips the setup_sorting().
Fixes: ad0de0971b7f ("perf report: Enable the runtime switching of perf data file")
Signed-off-by: Jin Yao <[email protected]>
Tested-by: Arnaldo Carvalho de Melo <[email protected]>
Acked-by: Jiri Olsa <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: Feng Tang <[email protected]>
Cc: Jin Yao <[email protected]>
Cc: Kan Liang <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/lib/perf/threadmap.c')
0 files changed, 0 insertions, 0 deletions