diff options
| author | Anton Protopopov <[email protected]> | 2025-04-30 12:08:20 +0000 |
|---|---|---|
| committer | Andrii Nakryiko <[email protected]> | 2025-04-30 16:04:20 +0000 |
| commit | 358b1c0f56ebb6996fcec7dcdcf6bae5dcbc8b6c (patch) | |
| tree | e6c67675445580d7ed2dd2b08ec86e633dabb068 /tools/lib/bpf | |
| parent | selftests/bpf: Fix kmem_cache iterator draining (diff) | |
| download | kernel-358b1c0f56ebb6996fcec7dcdcf6bae5dcbc8b6c.tar.gz kernel-358b1c0f56ebb6996fcec7dcdcf6bae5dcbc8b6c.zip | |
libbpf: Use proper errno value in linker
Return values of the linker_append_sec_data() and the
linker_append_elf_relos() functions are propagated all the
way up to users of libbpf API. In some error cases these
functions return -1 which will be seen as -EPERM from user's
point of view. Instead, return a more reasonable -EINVAL.
Fixes: faf6ed321cf6 ("libbpf: Add BPF static linker APIs")
Signed-off-by: Anton Protopopov <[email protected]>
Signed-off-by: Andrii Nakryiko <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'tools/lib/bpf')
| -rw-r--r-- | tools/lib/bpf/linker.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c index 56f5068e2eba..a469e5d4fee7 100644 --- a/tools/lib/bpf/linker.c +++ b/tools/lib/bpf/linker.c @@ -1376,7 +1376,7 @@ static int linker_append_sec_data(struct bpf_linker *linker, struct src_obj *obj } else { if (!secs_match(dst_sec, src_sec)) { pr_warn("ELF sections %s are incompatible\n", src_sec->sec_name); - return -1; + return -EINVAL; } /* "license" and "version" sections are deduped */ @@ -2223,7 +2223,7 @@ static int linker_append_elf_relos(struct bpf_linker *linker, struct src_obj *ob } } else if (!secs_match(dst_sec, src_sec)) { pr_warn("sections %s are not compatible\n", src_sec->sec_name); - return -1; + return -EINVAL; } /* shdr->sh_link points to SYMTAB */ |