diff options
| author | Jiasheng Jiang <[email protected]> | 2022-01-21 17:10:31 +0000 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2022-01-24 13:32:00 +0000 |
| commit | aa505ecccf2ae7546e0e262d574e18a9241f3005 (patch) | |
| tree | 3b986e8b75657a1d445c2f0ab94ac606e0b36ea6 /sound/soc/codecs/lpass-tx-macro.c | |
| parent | ASoC: Intel: sof_rt5682: add 512FS MCLK clock configuration (diff) | |
| download | kernel-aa505ecccf2ae7546e0e262d574e18a9241f3005.tar.gz kernel-aa505ecccf2ae7546e0e262d574e18a9241f3005.zip | |
ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio
Since the potential failure of the devm_regmap_init_mmio(), it will
return error pointer and be assigned to the regmap.
Then the error pointer will be dereferenced.
For example rx->regmap will be used in rx_macro_mclk_enable().
Therefore, it should be better to check it.
Fixes: af3d54b99764 ("ASoC: codecs: lpass-rx-macro: add support for lpass rx macro")
Fixes: c39667ddcfc5 ("ASoC: codecs: lpass-tx-macro: add support for lpass tx macro")
Fixes: 809bcbcecebf ("ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro")
Signed-off-by: Jiasheng Jiang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'sound/soc/codecs/lpass-tx-macro.c')
| -rw-r--r-- | sound/soc/codecs/lpass-tx-macro.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/codecs/lpass-tx-macro.c b/sound/soc/codecs/lpass-tx-macro.c index a4c0a155af56..9c96ab1bf84f 100644 --- a/sound/soc/codecs/lpass-tx-macro.c +++ b/sound/soc/codecs/lpass-tx-macro.c @@ -1821,6 +1821,8 @@ static int tx_macro_probe(struct platform_device *pdev) } tx->regmap = devm_regmap_init_mmio(dev, base, &tx_regmap_config); + if (IS_ERR(tx->regmap)) + return PTR_ERR(tx->regmap); dev_set_drvdata(dev, tx); |