diff options
| author | Julia Lawall <[email protected]> | 2010-06-20 11:24:35 +0000 |
|---|---|---|
| committer | Jiri Kosina <[email protected]> | 2010-06-21 11:41:54 +0000 |
| commit | ca9fe1588427f246ad4c389b0170b29a432804b6 (patch) | |
| tree | 79a8faa2a25efe789fb06be64bff5034c8659f65 /security/selinux/hooks.c | |
| parent | HID: ntrig: add support for new firwmare versions (diff) | |
| download | kernel-ca9fe1588427f246ad4c389b0170b29a432804b6.tar.gz kernel-ca9fe1588427f246ad4c389b0170b29a432804b6.zip | |
HID: eliminate a double lock in debug code
The path around the loop ends with the lock held, so the call to mutex_lock
is moved before the beginning of the loop.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@locked@
expression E1;
position p;
@@
read_lock(E1@p,...);
@r exists@
expression x <= locked.E1;
expression locked.E1;
expression E2;
identifier lock;
position locked.p,p1,p2;
@@
*lock@p1 (E1@p,...);
... when != E1
when != \(x = E2\|&x\)
*lock@p2 (E1,...);
// </smpl>
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
Diffstat (limited to 'security/selinux/hooks.c')
0 files changed, 0 insertions, 0 deletions
