aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/mod/file2alias.c
diff options
context:
space:
mode:
authorKory Maincent <[email protected]>2023-10-19 13:16:41 +0000
committerJakub Kicinski <[email protected]>2023-10-19 16:27:12 +0000
commit524515020f2552759a7ef1c9d03e7dac9b1ff3c2 (patch)
treef8707dd3d4ae689e547114e61d64b8302fadb7f2 /scripts/mod/file2alias.c
parentMerge branch 'mptcp-fixes-for-v6-6' (diff)
downloadkernel-524515020f2552759a7ef1c9d03e7dac9b1ff3c2.tar.gz
kernel-524515020f2552759a7ef1c9d03e7dac9b1ff3c2.zip
Revert "ethtool: Fix mod state of verbose no_mask bitset"
This reverts commit 108a36d07c01edbc5942d27c92494d1c6e4d45a0. It was reported that this fix breaks the possibility to remove existing WoL flags. For example: ~$ ethtool lan2 ... Supports Wake-on: pg Wake-on: d ... ~$ ethtool -s lan2 wol gp ~$ ethtool lan2 ... Wake-on: pg ... ~$ ethtool -s lan2 wol d ~$ ethtool lan2 ... Wake-on: pg ... This worked correctly before this commit because we were always updating a zero bitmap (since commit 6699170376ab ("ethtool: fix application of verbose no_mask bitset"), that is) so that the rest was left zero naturally. But now the 1->0 change (old_val is true, bit not present in netlink nest) no longer works. Reported-by: Oleksij Rempel <[email protected]> Reported-by: Michal Kubecek <[email protected]> Closes: https://lore.kernel.org/netdev/[email protected]/ Cc: [email protected] Fixes: 108a36d07c01 ("ethtool: Fix mod state of verbose no_mask bitset") Signed-off-by: Kory Maincent <[email protected]> Reviewed-by: Michal Kubecek <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'scripts/mod/file2alias.c')
0 files changed, 0 insertions, 0 deletions