diff options
| author | Ulf Magnusson <[email protected]> | 2017-10-08 17:35:44 +0000 |
|---|---|---|
| committer | Masahiro Yamada <[email protected]> | 2018-01-21 15:49:26 +0000 |
| commit | ae7440ef0c8013d68c00dad6900e7cce5311bb1c (patch) | |
| tree | db7b1c09f2a860a317e06a8158fd0a7586676fa9 /scripts/kconfig/expr.c | |
| parent | kconfig: Don't leak main menus during parsing (diff) | |
| download | kernel-ae7440ef0c8013d68c00dad6900e7cce5311bb1c.tar.gz kernel-ae7440ef0c8013d68c00dad6900e7cce5311bb1c.zip | |
kconfig: Fix automatic menu creation mem leak
expr_trans_compare() always allocates and returns a new expression,
giving the following leak outline:
...
*Allocate*
basedep = expr_trans_compare(basedep, E_UNEQUAL, &symbol_no);
...
for (menu = parent->next; menu; menu = menu->next) {
...
*Copy*
dep2 = expr_copy(basedep);
...
*Free copy*
expr_free(dep2);
}
*basedep lost!*
Fix by freeing 'basedep' after the loop.
Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix:
LEAK SUMMARY:
definitely lost: 344,376 bytes in 14,349 blocks
...
Summary after the fix:
LEAK SUMMARY:
definitely lost: 44,448 bytes in 1,852 blocks
...
Signed-off-by: Ulf Magnusson <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
Diffstat (limited to 'scripts/kconfig/expr.c')
0 files changed, 0 insertions, 0 deletions