aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/gcc-plugins
diff options
context:
space:
mode:
authorRafael J. Wysocki <[email protected]>2025-05-29 13:40:43 +0000
committerRafael J. Wysocki <[email protected]>2025-05-29 15:34:18 +0000
commit70523f335734b0b42f97647556d331edf684c7dc (patch)
treefc58afc64b98604004a51638effc3759b9dcf633 /scripts/gcc-plugins
parentcpuidle: psci: Fix uninitialized variable in dt_idle_state_present() (diff)
downloadkernel-70523f335734b0b42f97647556d331edf684c7dc.tar.gz
kernel-70523f335734b0b42f97647556d331edf684c7dc.zip
Revert "x86/smp: Eliminate mwait_play_dead_cpuid_hint()"
Revert commit 96040f7273e2 ("x86/smp: Eliminate mwait_play_dead_cpuid_hint()") because it introduced a significant power regression on systems that start with "nosmt" in the kernel command line. Namely, on such systems, SMT siblings permanently go offline early, when cpuidle has not been initialized yet, so after the above commit, hlt_play_dead() is called for them. Later on, when the processor attempts to enter a deep package C-state, including PC10 which is requisite for reaching minimum power in suspend-to-idle, it is not able to do that because of the SMT siblings staying in C1 (which they have been put into by HLT). As a result, the idle power (including power in suspend-to-idle) rises quite dramatically on those systems with all of the possible consequences, which (needless to say) may not be expected by their users. This issue is hard to debug and potentially dangerous, so it needs to be addressed as soon as possible in a way that will work for 6.15.y, hence the revert. Of course, after this revert, the issue that commit 96040f7273e2 attempted to address will be back and it will need to be fixed again later. Fixes: 96040f7273e2 ("x86/smp: Eliminate mwait_play_dead_cpuid_hint()") Reported-by: Todd Brandt <[email protected]> Tested-by: Todd Brandt <[email protected]> Cc: 6.15+ <[email protected]> # 6.15+ Signed-off-by: Rafael J. Wysocki <[email protected]> Acked-by: Dave Hansen <[email protected]> Link: https://patch.msgid.link/[email protected]
Diffstat (limited to 'scripts/gcc-plugins')
0 files changed, 0 insertions, 0 deletions