diff options
| author | Brian Foster <[email protected]> | 2021-02-11 01:27:20 +0000 |
|---|---|---|
| committer | Darrick J. Wong <[email protected]> | 2021-02-11 01:27:20 +0000 |
| commit | e4826691cc7e5458bcb659935d0092bcf3f08c20 (patch) | |
| tree | 970c4310df600a976bbf7d0dffe2d56369ebabd5 /scripts/gcc-plugins/randomize_layout_plugin.c | |
| parent | xfs: fix rst syntax error in admin guide (diff) | |
| download | kernel-e4826691cc7e5458bcb659935d0092bcf3f08c20.tar.gz kernel-e4826691cc7e5458bcb659935d0092bcf3f08c20.zip | |
xfs: restore shutdown check in mapped write fault path
XFS triggers an iomap warning in the write fault path due to a
!PageUptodate() page if a write fault happens to occur on a page
that recently failed writeback. The iomap writeback error handling
code can clear the Uptodate flag if no portion of the page is
submitted for I/O. This is reproduced by fstest generic/019, which
combines various forms of I/O with simulated disk failures that
inevitably lead to filesystem shutdown (which then unconditionally
fails page writeback).
This is a regression introduced by commit f150b4234397 ("xfs: split
the iomap ops for buffered vs direct writes") due to the removal of
a shutdown check and explicit error return in the ->iomap_begin()
path used by the write fault path. The explicit error return
historically translated to a SIGBUS, but now carries on with iomap
processing where it complains about the unexpected state. Restore
the shutdown check to xfs_buffered_write_iomap_begin() to restore
historical behavior.
Fixes: f150b4234397 ("xfs: split the iomap ops for buffered vs direct writes")
Signed-off-by: Brian Foster <[email protected]>
Reviewed-by: Eric Sandeen <[email protected]>
Reviewed-by: Darrick J. Wong <[email protected]>
Signed-off-by: Darrick J. Wong <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/randomize_layout_plugin.c')
0 files changed, 0 insertions, 0 deletions
