diff options
| author | Ben Hutchings <[email protected]> | 2018-01-22 20:11:06 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2018-01-23 04:13:07 +0000 |
| commit | 1995266727fa8143897e89b55f5d3c79aa828420 (patch) | |
| tree | 2955860ce332561b8021ac8f07141e8a6849ad62 /scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h | |
| parent | orangefs: initialize op on loop restart in orangefs_devreq_read (diff) | |
| download | kernel-1995266727fa8143897e89b55f5d3c79aa828420.tar.gz kernel-1995266727fa8143897e89b55f5d3c79aa828420.zip | |
nfsd: auth: Fix gid sorting when rootsquash enabled
Commit bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility
group_info allocators") appears to break nfsd rootsquash in a pretty
major way.
It adds a call to groups_sort() inside the loop that copies/squashes
gids, which means the valid gids are sorted along with the following
garbage. The net result is that the highest numbered valid gids are
replaced with any lower-valued garbage gids, possibly including 0.
We should sort only once, after filling in all the gids.
Fixes: bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility ...")
Signed-off-by: Ben Hutchings <[email protected]>
Acked-by: J. Bruce Fields <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h')
0 files changed, 0 insertions, 0 deletions