diff options
| author | Thomas Gleixner <[email protected]> | 2021-07-29 21:51:44 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2021-08-10 08:59:20 +0000 |
| commit | 361fd37397f77578735907341579397d5bed0a2d (patch) | |
| tree | 80cd301ae579f8afb34daad06971230f5672481f /scripts/clang-tools/gen_compile_commands.py | |
| parent | PCI/MSI: Enforce MSI[X] entry updates to be visible (diff) | |
| download | kernel-361fd37397f77578735907341579397d5bed0a2d.tar.gz kernel-361fd37397f77578735907341579397d5bed0a2d.zip | |
PCI/MSI: Do not set invalid bits in MSI mask
msi_mask_irq() takes a mask and a flags argument. The mask argument is used
to mask out bits from the cached mask and the flags argument to set bits.
Some places invoke it with a flags argument which sets bits which are not
used by the device, i.e. when the device supports up to 8 vectors a full
unmask in some places sets the mask to 0xFFFFFF00. While devices probably
do not care, it's still bad practice.
Fixes: 7ba1930db02f ("PCI MSI: Unmask MSI if setup failed")
Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Marc Zyngier <[email protected]>
Reviewed-by: Marc Zyngier <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'scripts/clang-tools/gen_compile_commands.py')
0 files changed, 0 insertions, 0 deletions