diff options
| author | Ilpo Järvinen <[email protected]> | 2025-11-10 10:50:43 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2025-11-26 12:16:53 +0000 |
| commit | 2bf95a9bcb50002ca9d47403d60aedaeb2e19abe (patch) | |
| tree | cb262479d17ffd1884fa94a4c75daa6f7ff1e986 /scripts/basic/docproc.c | |
| parent | serial: amba-pl011: prefer dma_mapping_error() over explicit address checking (diff) | |
| download | kernel-2bf95a9bcb50002ca9d47403d60aedaeb2e19abe.tar.gz kernel-2bf95a9bcb50002ca9d47403d60aedaeb2e19abe.zip | |
serial: 8250: Fix 8250_rsa symbol loop
Depmod fails for a kernel made with:
make allnoconfig
echo -e "CONFIG_MODULES=y\nCONFIG_SERIAL_8250=m\nCONFIG_SERIAL_8250_EXTENDED=y\nCONFIG_SERIAL_8250_RSA=y" >> .config
make olddefconfig
...due to a dependency loop:
depmod: ERROR: Cycle detected: 8250 -> 8250_base -> 8250
depmod: ERROR: Found 2 modules in dependency cycles!
This is caused by the move of 8250 RSA code from 8250_port.c (in
8250_base.ko) into 8250_rsa.c (in 8250.ko) by the commit 5a128fb475fb
("serial: 8250: move RSA functions to 8250_rsa.c"). The commit
b20d6576cdb3 ("serial: 8250: export RSA functions") tried to fix a
missing symbol issue with EXPORTs but those then cause this dependency
cycle.
Break dependency loop by moving 8250_rsa.o from 8250.ko to 8250_base.ko
and by passing univ8250_port_base_ops to univ8250_rsa_support() that
can make a local copy of it.
Reported-by: Stephen Rothwell <[email protected]>
Reported-by: Alex Davis <[email protected]>
Fixes: 5a128fb475fb ("serial: 8250: move RSA functions to 8250_rsa.c")
Fixes: b20d6576cdb3 ("serial: 8250: export RSA functions")
Cc: stable <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Link: https://lore.kernel.org/all/CADiockCvM6v+d+UoFZpJSMoLAdpy99_h-hJdzUsdfaWGn3W7-g@mail.gmail.com/
Reviewed-by: Andy Shevchenko <[email protected]>
Reviewed-by: Jiri Slaby <[email protected]>
Signed-off-by: Ilpo Järvinen <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'scripts/basic/docproc.c')
0 files changed, 0 insertions, 0 deletions
