aboutsummaryrefslogtreecommitdiffstats
path: root/rust/helpers/task.c
diff options
context:
space:
mode:
authorMarc Kleine-Budde <[email protected]>2025-07-15 20:35:46 +0000
committerMarc Kleine-Budde <[email protected]>2025-07-22 10:55:13 +0000
commitc1f3f9797c1f44a762e6f5f72520b2e520537b52 (patch)
treeccf5826e59d9192276e1d7cbc3e80e5cdcd5bb06 /rust/helpers/task.c
parentgve: Fix stuck TX queue for DQ queue format (diff)
downloadkernel-c1f3f9797c1f44a762e6f5f72520b2e520537b52.tar.gz
kernel-c1f3f9797c1f44a762e6f5f72520b2e520537b52.zip
can: netlink: can_changelink(): fix NULL pointer deref of struct can_priv::do_set_mode
Andrei Lalaev reported a NULL pointer deref when a CAN device is restarted from Bus Off and the driver does not implement the struct can_priv::do_set_mode callback. There are 2 code path that call struct can_priv::do_set_mode: - directly by a manual restart from the user space, via can_changelink() - delayed automatic restart after bus off (deactivated by default) To prevent the NULL pointer deference, refuse a manual restart or configure the automatic restart delay in can_changelink() and report the error via extack to user space. As an additional safety measure let can_restart() return an error if can_priv::do_set_mode is not set instead of dereferencing it unchecked. Reported-by: Andrei Lalaev <[email protected]> Closes: https://lore.kernel.org/all/[email protected] Fixes: 39549eef3587 ("can: CAN Network device driver and Netlink interface") Link: https://patch.msgid.link/20250718-fix-nullptr-deref-do_set_mode-v1-1-0b520097bb96@pengutronix.de Signed-off-by: Marc Kleine-Budde <[email protected]>
Diffstat (limited to 'rust/helpers/task.c')
0 files changed, 0 insertions, 0 deletions