diff options
| author | Maxime Chevallier <[email protected]> | 2025-04-07 13:05:10 +0000 |
|---|---|---|
| committer | Paolo Abeni <[email protected]> | 2025-04-08 13:34:15 +0000 |
| commit | 4f038a6a02d20859a3479293cbf172b0f14cbdd6 (patch) | |
| tree | 959dc7b77133004a8721e709f341fa3d88441c75 /rust/helpers/platform.c | |
| parent | tc: Ensure we have enough buffer space when sending filter netlink notifications (diff) | |
| download | kernel-4f038a6a02d20859a3479293cbf172b0f14cbdd6.tar.gz kernel-4f038a6a02d20859a3479293cbf172b0f14cbdd6.zip | |
net: ethtool: Don't call .cleanup_data when prepare_data fails
There's a consistent pattern where the .cleanup_data() callback is
called when .prepare_data() fails, when it should really be called to
clean after a successful .prepare_data() as per the documentation.
Rewrite the error-handling paths to make sure we don't cleanup
un-prepared data.
Fixes: c781ff12a2f3 ("ethtool: Allow network drivers to dump arbitrary EEPROM data")
Reviewed-by: Kory Maincent <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Reviewed-by: Michal Kubecek <[email protected]>
Signed-off-by: Maxime Chevallier <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
Diffstat (limited to 'rust/helpers/platform.c')
0 files changed, 0 insertions, 0 deletions