diff options
| author | Justin Stitt <[email protected]> | 2023-08-11 16:33:51 +0000 |
|---|---|---|
| committer | Will Deacon <[email protected]> | 2023-08-16 14:50:55 +0000 |
| commit | d232606773a0b09ec7f1ffc25f63abe801d011fd (patch) | |
| tree | 4acee58567032dbe83d5ff4df70e13cb1460aac7 /rust/helpers.c | |
| parent | arm64: sysreg: Generate C compiler warnings on {read,write}_sysreg_s arguments (diff) | |
| download | kernel-d232606773a0b09ec7f1ffc25f63abe801d011fd.tar.gz kernel-d232606773a0b09ec7f1ffc25f63abe801d011fd.zip | |
arm64/sysreg: refactor deprecated strncpy
`strncpy` is deprecated for use on NUL-terminated destination strings
[1]. Which seems to be the case here due to the forceful setting of `buf`'s
tail to 0.
A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on its destination buffer argument which is
_not_ the case for `strncpy`!
In this case, we can simplify the logic and also check for any silent
truncation by using `strscpy`'s return value.
This should have no functional change and yet uses a more robust and
less ambiguous interface whilst reducing code complexity.
Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Suggested-by: Kees Cook <[email protected]>
Cc: [email protected]
Signed-off-by: Justin Stitt <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Will Deacon <[email protected]>
Diffstat (limited to 'rust/helpers.c')
0 files changed, 0 insertions, 0 deletions
