diff options
| author | David Ahern <[email protected]> | 2021-08-02 16:02:21 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2021-08-02 20:19:49 +0000 |
| commit | 28814cd18cd7bfb40321b95f85fd214111ccdf68 (patch) | |
| tree | e631b66f15f481b47705efdd7f31badcd0d7c80d /net/unix/unix_bpf.c | |
| parent | net: phy: mscc: make some arrays static const, makes object smaller (diff) | |
| download | kernel-28814cd18cd7bfb40321b95f85fd214111ccdf68.tar.gz kernel-28814cd18cd7bfb40321b95f85fd214111ccdf68.zip | |
ipv4: Fix refcount warning for new fib_info
Ioana reported a refcount warning when booting over NFS:
[ 5.042532] ------------[ cut here ]------------
[ 5.047184] refcount_t: addition on 0; use-after-free.
[ 5.052324] WARNING: CPU: 7 PID: 1 at lib/refcount.c:25 refcount_warn_saturate+0xa4/0x150
...
[ 5.167201] Call trace:
[ 5.169635] refcount_warn_saturate+0xa4/0x150
[ 5.174067] fib_create_info+0xc00/0xc90
[ 5.177982] fib_table_insert+0x8c/0x620
[ 5.181893] fib_magic.isra.0+0x110/0x11c
[ 5.185891] fib_add_ifaddr+0xb8/0x190
[ 5.189629] fib_inetaddr_event+0x8c/0x140
fib_treeref needs to be set after kzalloc. The old code had a ++ which
led to the confusion when the int was replaced by a refcount_t.
Fixes: 79976892f7ea ("net: convert fib_treeref from int to refcount_t")
Signed-off-by: David Ahern <[email protected]>
Reported-by: Ioana Ciornei <[email protected]>
Cc: Yajun Deng <[email protected]>
Tested-by: Matthieu Baerts <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/unix/unix_bpf.c')
0 files changed, 0 insertions, 0 deletions